Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Suppress save dialog from browser token login #3579

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 11, 2024

Backport of #3519 to release/8.0

/cc @JamesNK

Customer Impact

Related to browser token security. Prevents the browser from asking to remember the token. We never want them to do that as its a new value each time.

Testing

Manual testing.

Risk

Low. Just an HTML attribute.

Regression?

No

Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added the Servicing-consider Issue for next servicing release review label Apr 11, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 11, 2024
@danmoseley danmoseley enabled auto-merge (squash) April 11, 2024 00:26
@danmoseley danmoseley merged commit 036b05b into release/8.0 Apr 11, 2024
7 checks passed
@danmoseley danmoseley deleted the backport/pr-3519-to-release/8.0 branch April 11, 2024 01:35
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants